Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1052493005: Revert of Prime the landing pad for the new video rendering pipeline. (Closed)

Created:
5 years, 8 months ago by gunsch
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, avayvod+watch_chromium.org, viettrungluu+watch_chromium.org, jam, mcasas+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org, darin (slow to review), servolk, lcwu1, gunsch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Prime the landing pad for the new video rendering pipeline. (patchset #9 id:200001 of https://codereview.chromium.org/1053113002/) Reason for revert: Actually, given the complexity of this change (not a one-line Cast fix) and the fact that we have broken Cast trybots running @ 100% right now (http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/), I'm going to revert this. I'm working on a brief patch of what I expect would need to be done for Cast and will upload/mail shortly. Original issue's description: > Prime the landing pad for the new video rendering pipeline. > > This is not a functional change, it only updates the interfaces and > call sites in preparation for switching to a vsync based video > rendering pipeline. > > Some notes: > - Plumbs a VideoRendererSink into the the rendering pipeline; similar to > how we have an AudioRendererSink. > - A couple VideoRendererSink mocks are introduced which will be short > lived. Like audio, we will need fakes which can pump consumption tasks. > - The "PaintCB" callback has been temporarily placed on the new sink > interface such that in the field experiments can be run comparing the > performance of the video rendering approaches. > - Finally nukes Player_X11 since setting up a vsync renderer just for > unused tool code isn't worth the effort. > - Since compositor callbacks may stop due to visibility changes, the > new VideoRendererImpl will use a countdown timer to pump video playback > as frames expire; expired frames will not count as dropped. > - Since canvas/WebGL requires frame updates in the background a new > method has been added to VideoFrameCompositor to return the current > frame if it was updated with 250ms, or to request a new one and return > the updated one. > > Subsequent work: > - sunnyps@ will be switching VideoFrameProviderClientImpl over to using > a BeginFrameObserver, which will ultimately drive the Render() callbacks. > - dalecurtis@ will land the VideoRendererAlgorithm which powers the new > rendering pipeline. > > BUG=439548 > TEST=everything works as is. > > Committed: https://crrev.com/e7f41df2541aea7c99f7965874f9c5ce901899e5 > Cr-Commit-Position: refs/heads/master@{#325183} TBR=xhwang@chromium.org,sunnyps@chromium.org,brianderson@chromium.org,enne@chromium.org,dpranke@chromium.org,danakj@chromium.org,dalecurtis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=439548 Committed: https://crrev.com/24413fda915450e43423cfe3902f887b6a937ae8 Cr-Commit-Position: refs/heads/master@{#325187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1221 lines, -481 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/video_frame_provider.h View 3 chunks +21 lines, -49 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_video_frame_provider.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_video_frame_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M media/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +13 lines, -11 lines 0 comments Download
M media/base/pipeline.h View 3 chunks +4 lines, -0 lines 0 comments Download
M media/base/pipeline.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M media/base/pipeline_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M media/base/renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/renderer_factory.h View 2 chunks +2 lines, -5 lines 0 comments Download
M media/base/video_renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download
D media/base/video_renderer_sink.h View 1 chunk +0 lines, -64 lines 0 comments Download
M media/blink/video_frame_compositor.h View 2 chunks +13 lines, -65 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 2 chunks +5 lines, -84 lines 0 comments Download
M media/blink/video_frame_compositor_unittest.cc View 7 chunks +11 lines, -16 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 5 chunks +18 lines, -9 lines 0 comments Download
M media/media.gyp View 1 chunk +38 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 5 chunks +5 lines, -3 lines 0 comments Download
M media/mojo/services/renderer_config.h View 3 chunks +2 lines, -4 lines 0 comments Download
M media/mojo/services/renderer_config.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/mojo/services/renderer_config_default.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M media/renderers/default_renderer_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M media/renderers/renderer_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/renderers/renderer_impl.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M media/renderers/video_renderer_impl.h View 6 chunks +1 line, -10 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 5 chunks +3 lines, -17 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 15 chunks +18 lines, -27 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 3 chunks +9 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.h View 2 chunks +0 lines, -15 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 4 chunks +3 lines, -9 lines 0 comments Download
A media/tools/player_x11/data_source_logger.h View 1 chunk +41 lines, -0 lines 0 comments Download
A media/tools/player_x11/data_source_logger.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A media/tools/player_x11/gl_video_renderer.h View 1 chunk +43 lines, -0 lines 0 comments Download
A media/tools/player_x11/gl_video_renderer.cc View 1 chunk +251 lines, -0 lines 0 comments Download
A media/tools/player_x11/player_x11.cc View 1 chunk +311 lines, -0 lines 0 comments Download
A media/tools/player_x11/x11_video_renderer.h View 1 chunk +47 lines, -0 lines 0 comments Download
A media/tools/player_x11/x11_video_renderer.cc View 1 chunk +215 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gunsch
Created Revert of Prime the landing pad for the new video rendering pipeline.
5 years, 8 months ago (2015-04-15 06:01:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052493005/1
5 years, 8 months ago (2015-04-15 06:02:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 06:03:57 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 06:04:49 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/24413fda915450e43423cfe3902f887b6a937ae8
Cr-Commit-Position: refs/heads/master@{#325187}

Powered by Google App Engine
This is Rietveld 408576698