Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052383003: Disable closure wrapping by default (Closed)

Created:
5 years, 8 months ago by vsm
Modified:
5 years, 8 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -569 lines) Patch
M lib/runtime/dart/_internal.js View 5 chunks +6 lines, -6 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 5 chunks +7 lines, -7 lines 0 comments Download
M lib/runtime/dart/async.js View 16 chunks +25 lines, -25 lines 0 comments Download
M lib/runtime/dart/collection.js View 8 chunks +20 lines, -20 lines 0 comments Download
M lib/runtime/dart/convert.js View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/core.js View 10 chunks +13 lines, -13 lines 0 comments Download
M lib/runtime/dart/isolate.js View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/options.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/checker/checker_test.dart View 17 chunks +64 lines, -65 lines 3 comments Download
M test/dart_codegen/expect/_internal/iterable.dart View 8 chunks +20 lines, -48 lines 0 comments Download
M test/dart_codegen/expect/async/broadcast_stream_controller.dart View 2 chunks +5 lines, -13 lines 0 comments Download
M test/dart_codegen/expect/async/future.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/dart_codegen/expect/async/future_impl.dart View 6 chunks +12 lines, -20 lines 0 comments Download
M test/dart_codegen/expect/async/schedule_microtask.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/async/stream.dart View 19 chunks +38 lines, -82 lines 0 comments Download
M test/dart_codegen/expect/async/stream_controller.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M test/dart_codegen/expect/async/stream_impl.dart View 4 chunks +12 lines, -28 lines 0 comments Download
M test/dart_codegen/expect/async/stream_pipe.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/dart_codegen/expect/async/stream_transformers.dart View 3 chunks +17 lines, -39 lines 0 comments Download
M test/dart_codegen/expect/async/timer.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M test/dart_codegen/expect/async/zone.dart View 11 chunks +35 lines, -39 lines 0 comments Download
M test/dart_codegen/expect/c/c.dart View 1 chunk +5 lines, -10 lines 0 comments Download
M test/dart_codegen/expect/collection/splay_tree.dart View 4 chunks +9 lines, -25 lines 0 comments Download
M test/dart_codegen/expect/convert/json.dart View 12 chunks +20 lines, -32 lines 0 comments Download
M test/dart_codegen/expect/convert/string_conversion.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M test/dart_codegen/expect/convert/utf.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M test/dart_codegen/expect/core/uri.dart View 13 chunks +25 lines, -49 lines 0 comments Download
M test/dart_codegen/expect/d/d.dart View 1 chunk +5 lines, -11 lines 0 comments Download
M test/dart_codegen/expect/types.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vsm
https://codereview.chromium.org/1052383003/diff/1/test/checker/checker_test.dart File test/checker/checker_test.dart (right): https://codereview.chromium.org/1052383003/diff/1/test/checker/checker_test.dart#newcode704 test/checker/checker_test.dart:704: left = /*pass should be warning:DownCastComposite*/top; We're missing handling ...
5 years, 8 months ago (2015-04-03 21:09:34 UTC) #2
vsm
5 years, 8 months ago (2015-04-03 21:09:36 UTC) #3
Leaf
lgtm https://codereview.chromium.org/1052383003/diff/1/test/checker/checker_test.dart File test/checker/checker_test.dart (right): https://codereview.chromium.org/1052383003/diff/1/test/checker/checker_test.dart#newcode704 test/checker/checker_test.dart:704: left = /*pass should be warning:DownCastComposite*/top; On 2015/04/03 ...
5 years, 8 months ago (2015-04-03 21:24:59 UTC) #4
vsm
5 years, 8 months ago (2015-04-03 21:26:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
067294a331c6fd39858375993ea8c01c9961ad55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698