Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1052383002: Reland: Add button to add new FSP services to Files app. (Closed)

Created:
5 years, 8 months ago by mtomasz
Modified:
5 years, 8 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Add button to add new FSP services to Files app. This CL adds a FSP suggest dialog which can be shown by clicking the button at the end of the left nav. TBR=hirono@chromium.org TEST=Tested manually by clicking on the new button in the left nav. BUG=471722 Committed: https://crrev.com/c1c15b3bd8fd1fa749e5544d8a167079290a9d49 Cr-Commit-Position: refs/heads/master@{#323577}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -101 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_types.css View 1 chunk +6 lines, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/2x/add.png View Binary file 0 comments Download
A ui/file_manager/file_manager/foreground/images/volumes/add.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/cws_container_client.js View 2 chunks +7 lines, -13 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +4 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model.js View 7 chunks +43 lines, -35 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 6 chunks +93 lines, -16 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js View 9 chunks +53 lines, -26 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/copy_between_windows.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/integration_tests/file_manager/file_display.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/integration_tests/file_manager/folder_shortcuts.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtomasz
Already l g t m'ed by @hirono at crbug.com/1056433003.
5 years, 8 months ago (2015-04-02 23:27:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052383002/1
5 years, 8 months ago (2015-04-03 00:55:00 UTC) #4
mtomasz
Committed patchset #1 (id:1) manually as c1c15b3bd8fd1fa749e5544d8a167079290a9d49 (presubmit successful).
5 years, 8 months ago (2015-04-03 02:12:57 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:29:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1c15b3bd8fd1fa749e5544d8a167079290a9d49
Cr-Commit-Position: refs/heads/master@{#323577}

Powered by Google App Engine
This is Rietveld 408576698