runtime/vm/service.cc - Issue 1052373010: Fix service rpc parameter validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/service.cc

Issue 1052373010: Fix service rpc parameter validation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/service.cc

diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc

index d85b458680b7329d5eebbb3ebd7a34a167b83e61..036bb832f9b9ae2f61ed7538a2e18acb884a27a6 100644

--- a/runtime/vm/service.cc

+++ b/runtime/vm/service.cc

@@ -409,7 +409,7 @@ static bool ValidateParameters(const MethodParameter* const* parameters,

PrintMissingParamError(js, name);

return false;

}

- if (!parameter->Validate(value)) {

+ if (has_parameter && !parameter->Validate(value)) {

PrintInvalidParamError(js, name);

return false;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »