Issue 1052373008: [chrome/test] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052373008: [chrome/test] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Mostyn Bramley-Moore

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/test BUG=466848 Committed: https://crrev.com/7db3046f8afc7d07e8901c1dbc41f140a4780dd0 Cr-Commit-Position: refs/heads/master@{#326026}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/test/base/testing_io_thread_state.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/test/base/tracing.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/21 13:12:36, sky wrote: > LGTM Thanks sky for lgtm

5 years, 8 months ago (2015-04-21 13:15:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052373008/1

5 years, 8 months ago (2015-04-21 13:15:49 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-21 14:16:05 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7db3046f8afc7d07e8901c1dbc41f140a4780dd0
Cr-Commit-Position: refs/heads/master@{#326026}