Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1052373007: Limit recent SVG baseline tests to a stable subset (Closed)

Created:
5 years, 8 months ago by davve
Modified:
5 years, 8 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Limit recent SVG baseline tests to a stable subset For currently unknown reasons, some baseline-shift and alignment-baseline values does not result in stable positions across zoom levels on the Windows bots. See win_blink_rel failures in https://codereview.chromium.org/1081813003/ for patch set 4 for details. The issue does not however reproduce in a Win7 VM. Leave these problematic values out and remove TestExpectations line. BUG=476344, 478703 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -25 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/svg/custom/zoomed-alignment-baseline.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/svg/custom/zoomed-alignment-baseline-expected.txt View 2 chunks +0 lines, -12 lines 0 comments Download
M LayoutTests/svg/custom/zoomed-baseline-shift.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/zoomed-baseline-shift-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davve
Couldn't really figure out the Windows failures* so I'm just removing the tests that fails. ...
5 years, 8 months ago (2015-04-20 10:24:11 UTC) #2
fs
On 2015/04/20 10:24:11, David Vest wrote: > Couldn't really figure out the Windows failures* so ...
5 years, 8 months ago (2015-04-20 10:46:34 UTC) #3
davve
On 2015/04/20 10:46:34, fs wrote: > Should we file some sort of tracking (FYI) bug ...
5 years, 8 months ago (2015-04-20 13:01:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052373007/1
5 years, 8 months ago (2015-04-20 13:02:24 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 14:07:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194028

Powered by Google App Engine
This is Rietveld 408576698