Add DBus bindings for BLE Advertisement.

chromeos/dbus/bluetooth_advertisement_manager_client.h

+// Copyright 2013 The Chromium Authors. All rights reserved.

[armansito, 2015/04/09 22:08:32]

s/2013/2015

[rkc, 2015/04/13 19:47:46]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_BLUETOOTH_ADVERTISEMENT_MANAGER_CLIENT_H_
+#define CHROMEOS_DBUS_BLUETOOTH_ADVERTISEMENT_MANAGER_CLIENT_H_

[armansito, 2015/04/09 22:08:32]

This is called "LEAdvertisingManager1" in BlueZ, so let's name this class
BluetoothLeAdvertisingManagerClient

[rkc, 2015/04/13 19:47:46]

Done.

+
+#include <string>
+#include <vector>
+
+#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chromeos/chromeos_export.h"
+#include "chromeos/dbus/dbus_client.h"
+#include "dbus/object_path.h"
+
+namespace chromeos {
+
+// BluetoothAdvertisementManagerClient is used to communicate with the profile
+// manager object of the BlueZ daemon.
+class CHROMEOS_EXPORT BluetoothAdvertisementManagerClient : public DBusClient {

[armansito, 2015/04/09 22:08:32]

You'll need an observer interface for this class to signal when this interface
gets added and removed, since there's no singleton advertising manager. See
BluetoothAdapterClient for an example.

[rkc, 2015/04/13 19:47:46]

Done.

+ public:
+  ~BluetoothAdvertisementManagerClient() override;
+
+  // The ErrorCallback is used by adapter methods to indicate failure.

[armansito, 2015/04/09 22:08:32]

s/adapter methods/advertising manager methods/

[rkc, 2015/04/13 19:47:46]

Done.

+  // It receives two arguments: the name of the error in |error_name| and
+  // an optional message in |error_message|.
+  typedef base::Callback<void(const std::string& error_name,

[armansito, 2015/04/09 22:08:32]

'using' instead of 'typedef'

[rkc, 2015/04/13 19:47:46]

Done.

+                              const std::string& error_message)> ErrorCallback;
+
+  // Registers an advertisement with the DBus object path |obj_path| with
+  // BlueZ's advertisement manager.

[armansito, 2015/04/09 22:08:32]

s/advertisement manager/advertising manager/, to be consistent with BlueZ's API
naming.

[rkc, 2015/04/13 19:47:46]

Done.

+  virtual void RegisterAdvertisement(const dbus::ObjectPath& obj_path,

[armansito, 2015/04/09 22:08:32]

s/obj_path/object_path/

[armansito, 2015/04/09 22:08:32]

You'll need to take in the object path of the advertising manager here, as well
as the path to the advertisement object.

[rkc, 2015/04/13 19:47:46]

Done.

[rkc, 2015/04/13 19:47:46]

Done.

+                                     const base::Closure& callback,
+                                     const ErrorCallback& error_callback) = 0;
+
+  // Unregisters an advertisement with the DBus object path |obj_path| with
+  // BlueZ's advertisement manager.
+  virtual void UnregisterAdvertisement(const dbus::ObjectPath& profile_path,

[armansito, 2015/04/09 22:08:32]

s/profile_path/object_path/, and add "advertisement_path" as an additional
argument.

[rkc, 2015/04/13 19:47:46]

Done.

+                                       const base::Closure& callback,
+                                       const ErrorCallback& error_callback) = 0;
+
+  // Creates the instance.
+  static BluetoothAdvertisementManagerClient* Create();
+
+  // Constants used to indicate exceptional error conditions.
+  static const char kNoResponseError[];
+
+ protected:
+  BluetoothAdvertisementManagerClient();
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(BluetoothAdvertisementManagerClient);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_DBUS_BLUETOOTH_ADVERTISEMENT_MANAGER_CLIENT_H_