Issue 1052363002: Fix a FIXME - correctly calculate the main size when writing modes are involved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052363002: Fix a FIXME - correctly calculate the main size when writing modes are involved. (Closed)

Created:
5 years, 8 months ago by cbiesinger

Modified:
5 years, 8 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix a FIXME - correctly calculate the main size when writing modes are involved. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193145

Patch Set 1 #

Patch Set 2 : test should be fixed now #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
A	LayoutTests/css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing.html	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
A +	LayoutTests/css3/flexbox/orthogonal-writing-modes-and-intrinsic-sizing-expected.txt	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/layout/LayoutFlexibleBox.cpp	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052363002/20001

5 years, 8 months ago (2015-04-03 21:31:05 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 22:55:12 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193145

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages