Issue 1052353005: Revert of Rebaseline layout tests after V8 roll

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1052353005: Revert of Rebaseline layout tests after V8 roll (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow

Modified:
5 years, 8 months ago

Reviewers:
kozy, pfeldman

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of Rebaseline layout tests after V8 roll (patchset #1 id:1 of https://codereview.chromium.org/1050993005/) Reason for revert: This expectation change prevents rolling V8 in Chromium trunk back to the V8 version that will be used in the M43 branch (which was in Chromium trunk earlier this week). Please don't bake in newer expectations until after the branch point. Original issue's description: > Rebaseline layout tests after V8 roll > > TBR=pfeldman@chromium.org > NOTRY=true > BUG=467386 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193012 TBR=pfeldman@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467386 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193108

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -4 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	LayoutTests/http/tests/security/window-named-proto-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/http/tests/security/xss-exception-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

Created Revert of Rebaseline layout tests after V8 roll

5 years, 8 months ago (2015-04-03 11:31:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052353005/1

5 years, 8 months ago (2015-04-03 11:31:47 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 11:32:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193108