Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: chrome/browser/android/dom_distiller/feedback_reporter_android.cc

Issue 1052353002: Disable android-view feedback for distiller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/dom_distiller/feedback_reporter_android.cc
diff --git a/chrome/browser/android/dom_distiller/feedback_reporter_android.cc b/chrome/browser/android/dom_distiller/feedback_reporter_android.cc
index c7d720c8637d1767b5c3bffcd15bab055699da69..16b73ec2e96b6089cc5195df5cf6dfe1d31555ea 100644
--- a/chrome/browser/android/dom_distiller/feedback_reporter_android.cc
+++ b/chrome/browser/android/dom_distiller/feedback_reporter_android.cc
@@ -49,6 +49,11 @@ void FeedbackReporterAndroid::ReplaceWebContents(JNIEnv* env,
void FeedbackReporterAndroid::DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) {
+ // TODO(mdjones): Remove all existing code for the android view version
cjhopman 2015/04/03 17:38:30 This is sort of weird because it breaks this class
mdjones 2015/04/03 18:49:21 Done.
+ // of the feedback overlay.
+ // NOTE: This stops the call to open feedback.
+ return;
+
JNIEnv* env = base::android::AttachCurrentThread();
ScopedJavaLocalRef<jobject> jobj = weak_java_feedback_reporter_.get(env);
if (jobj.is_null())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698