Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1052353002: Disable android-view feedback for distiller (Closed)

Created:
5 years, 8 months ago by mdjones
Modified:
5 years, 8 months ago
Reviewers:
cjhopman, nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable android-view feedback for distiller This change simply stops the android view version of the distiller feedback from opening. The code still needs to be removed. BUG=472890 Committed: https://crrev.com/067aae92776f2748786d7056c9039d3dbbfb1bec Cr-Commit-Position: refs/heads/master@{#324547}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/android/dom_distiller/feedback_reporter_android.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
mdjones
5 years, 8 months ago (2015-04-02 22:38:29 UTC) #2
cjhopman
https://codereview.chromium.org/1052353002/diff/1/chrome/browser/android/dom_distiller/feedback_reporter_android.cc File chrome/browser/android/dom_distiller/feedback_reporter_android.cc (right): https://codereview.chromium.org/1052353002/diff/1/chrome/browser/android/dom_distiller/feedback_reporter_android.cc#newcode52 chrome/browser/android/dom_distiller/feedback_reporter_android.cc:52: // TODO(mdjones): Remove all existing code for the android ...
5 years, 8 months ago (2015-04-03 17:38:31 UTC) #3
mdjones
https://codereview.chromium.org/1052353002/diff/1/chrome/browser/android/dom_distiller/feedback_reporter_android.cc File chrome/browser/android/dom_distiller/feedback_reporter_android.cc (right): https://codereview.chromium.org/1052353002/diff/1/chrome/browser/android/dom_distiller/feedback_reporter_android.cc#newcode52 chrome/browser/android/dom_distiller/feedback_reporter_android.cc:52: // TODO(mdjones): Remove all existing code for the android ...
5 years, 8 months ago (2015-04-03 18:49:21 UTC) #4
cjhopman
lgtm
5 years, 8 months ago (2015-04-03 18:54:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052353002/20001
5 years, 8 months ago (2015-04-06 20:27:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54349)
5 years, 8 months ago (2015-04-06 20:37:47 UTC) #9
mdjones
On 2015/04/06 20:37:47, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 8 months ago (2015-04-06 23:06:27 UTC) #10
nyquist
lgtm
5 years, 8 months ago (2015-04-09 19:38:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052353002/20001
5 years, 8 months ago (2015-04-09 20:24:35 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-10 01:05:40 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 01:06:32 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/067aae92776f2748786d7056c9039d3dbbfb1bec
Cr-Commit-Position: refs/heads/master@{#324547}

Powered by Google App Engine
This is Rietveld 408576698