[Files.app] Make menus accessible

[Files.app] Make menus accessible

This patch make the menus in Files.app accessible by Chromevox.

This patch works:
- Make the menuitems focusable
- Even the elements get lost focus, don't focus to the mainview

BUG=465938
TEST=manually tested

Committed: https://crrev.com/d1ea56130991d1893ce2fcfe555beed1b4cece2c
Cr-Commit-Position: refs/heads/master@{#323897}

[yoshiki, 2015-04-03 09:23:19]

yoshiki@chromium.org changed reviewers:
+ hirono@chromium.org

[yoshiki, 2015-04-03 09:23:31]

@hirono, PTAL. Thanks.

[hirono, 2015-04-03 09:30:02]

lgtm!

https://codereview.chromium.org/1052343004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/1052343004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:261:
menuitems[i].setAttribute('tabindex', '0');
Just confirmation: Should it be zero (items are included in TAB focus loop), or
negative values (items are not included in TAB focus loop)?

[yoshiki, 2015-04-03 12:24:38]

https://codereview.chromium.org/1052343004/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/1052343004/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:261:
menuitems[i].setAttribute('tabindex', '0');
On 2015/04/03 09:30:02, hirono wrote:
> Just confirmation: Should it be zero (items are included in TAB focus loop),
or
> negative values (items are not included in TAB focus loop)?

Any non-negative value is ok. I wrote explanation in the comment.

[yoshiki, 2015-04-03 12:24:41]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-04-03 12:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1052343004/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2015-04-03 12:24:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052343004/20001

[commit-bot: I haz the power, 2015-04-03 14:42:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 14:42:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2015-04-03 15:25:07]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-04-03 15:25:07]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1052343004/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2015-04-03 15:25:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052343004/40001

[commit-bot: I haz the power, 2015-04-03 17:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 17:04:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yoshiki, 2015-04-06 07:14:53]

The CQ bit was checked by yoshiki@chromium.org

[yoshiki, 2015-04-06 07:14:53]

The patchset sent to the CQ was uploaded after l-g-t-m from hirono@chromium.org
Link to the patchset: https://codereview.chromium.org/1052343004/#ps60001
(title: "fix test")

[commit-bot: I haz the power, 2015-04-06 07:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052343004/60001

[commit-bot: I haz the power, 2015-04-06 07:44:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-06 07:45:09]

Patchset 4 (id:??) landed as
https://crrev.com/d1ea56130991d1893ce2fcfe555beed1b4cece2c
Cr-Commit-Position: refs/heads/master@{#323897}