Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1052343003: Update guest's InputMethodActive each time we see a TextInputTypeChanged. (Closed)

Created:
5 years, 8 months ago by lazyboy
Modified:
5 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@imactive-fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update guest's InputMethodActive each time we see a TextInputTypeChanged. BUG=450641 Test=<TO_BE_FILLED_IN> Committed: https://crrev.com/a34ff62d4c3ea32f30915d3e800fe336bc2788f4 Cr-Commit-Position: refs/heads/master@{#324002}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 3 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lazyboy
5 years, 8 months ago (2015-04-02 22:59:02 UTC) #2
Fady Samuel
lgtm + nits. https://chromiumcodereview.appspot.com/1052343003/diff/1/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (right): https://chromiumcodereview.appspot.com/1052343003/diff/1/content/browser/browser_plugin/browser_plugin_guest.cc#newcode496 content/browser/browser_plugin/browser_plugin_guest.cc:496: if (guest_rwhv) { nit: Early exist ...
5 years, 8 months ago (2015-04-06 20:05:03 UTC) #3
lazyboy
https://chromiumcodereview.appspot.com/1052343003/diff/1/content/browser/browser_plugin/browser_plugin_guest.cc File content/browser/browser_plugin/browser_plugin_guest.cc (right): https://chromiumcodereview.appspot.com/1052343003/diff/1/content/browser/browser_plugin/browser_plugin_guest.cc#newcode496 content/browser/browser_plugin/browser_plugin_guest.cc:496: if (guest_rwhv) { On 2015/04/06 20:05:03, Fady Samuel wrote: ...
5 years, 8 months ago (2015-04-07 00:42:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052343003/20001
5 years, 8 months ago (2015-04-07 02:11:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 02:21:31 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 02:22:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a34ff62d4c3ea32f30915d3e800fe336bc2788f4
Cr-Commit-Position: refs/heads/master@{#324002}

Powered by Google App Engine
This is Rietveld 408576698