chrome/browser/download/download_permission_request.h - Issue 1052273005: Fix DownloadPermissionRequest crash when host_ disappears

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/download/download_permission_request.h

Issue 1052273005: Fix DownloadPermissionRequest crash when host_ disappears (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/download/download_permission_request.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PERMISSION_REQUEST_H_	5 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PERMISSION_REQUEST_H_

6 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PERMISSION_REQUEST_H_	6 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PERMISSION_REQUEST_H_

7	7

8 #include "base/basictypes.h"	8 #include "base/basictypes.h"

9 #include "base/memory/weak_ptr.h"	9 #include "base/memory/weak_ptr.h"

10 #include "chrome/browser/download/download_request_limiter.h"	10 #include "chrome/browser/download/download_request_limiter.h"

(...skipping 15 matching lines...) Expand all Loading...
26 base::string16 GetMessageTextFragment() const override;	26 base::string16 GetMessageTextFragment() const override;

27 bool HasUserGesture() const override;	27 bool HasUserGesture() const override;

28 GURL GetRequestingHostname() const override;	28 GURL GetRequestingHostname() const override;

29 void PermissionGranted() override;	29 void PermissionGranted() override;

30 void PermissionDenied() override;	30 void PermissionDenied() override;

31 void Cancelled() override;	31 void Cancelled() override;

32 void RequestFinished() override;	32 void RequestFinished() override;

33	33

34 private:	34 private:

35 base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host_;	35 base::WeakPtr<DownloadRequestLimiter::TabDownloadState> host_;

	36 GURL request_url_;

36	37

37 DISALLOW_COPY_AND_ASSIGN(DownloadPermissionRequest);	38 DISALLOW_COPY_AND_ASSIGN(DownloadPermissionRequest);

38 };	39 };

39	40

40 #endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PERMISSION_REQUEST_H_	41 #endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_PERMISSION_REQUEST_H_

OLD	NEW