Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1052253003: Revert of Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #1 id:1 of https://codereview.chromium.org/1099203004/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of Protect the emptiness of Array prototype elements with a PropertyCell. (patchset #7 id:120001 of https://codereview.chromium.org/1092043002/) > > Reason for revert: > MAC GCSTRESS failure on new test. > > Original issue's description: > > Protect the emptiness of Array prototype elements with a PropertyCell. > > > > Not just emptiness, but also a particular structure. > > > > BUG=v8:4044 > > LOG=N > > TBR=jkummerow@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4044 TBR=jkummerow@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4044 Committed: https://crrev.com/2631c9f5e383339bcceb18a93264c4a37a965f4a Cr-Commit-Position: refs/heads/master@{#28000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -27 lines) Patch
M src/builtins.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M src/compilation-dependencies.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/isolate.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +69 lines, -7 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 6 chunks +20 lines, -7 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M test/mjsunit/concurrent-initial-prototype-change.js View 1 chunk +8 lines, -0 lines 0 comments Download
A test/mjsunit/elide-double-hole-check-12.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of Protect the emptiness of Array prototype elements with a PropertyCell.
5 years, 8 months ago (2015-04-22 10:35:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052253003/1
5 years, 8 months ago (2015-04-22 10:35:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 10:35:29 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2631c9f5e383339bcceb18a93264c4a37a965f4a
Cr-Commit-Position: refs/heads/master@{#28000}

Powered by Google App Engine
This is Rietveld 408576698