Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: include/core/SkFontHost.h

Issue 105223006: Remove a layer of indirection and code from SkFontHost. (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Rebase, should now work due to Android changes. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkFontHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkFontHost.h
diff --git a/include/core/SkFontHost.h b/include/core/SkFontHost.h
index 4c5013fe4a044d7c0cc2cfc91950e30d89804719..a2cc04bc709726e0c993d5e9da37408bdea87089 100644
--- a/include/core/SkFontHost.h
+++ b/include/core/SkFontHost.h
@@ -90,42 +90,6 @@ public:
static void SetSubpixelOrder(LCDOrder order);
/** @deprecated get from Device. */
static LCDOrder GetSubpixelOrder();
-
-private:
- /** Return a new, closest matching typeface given either an existing family
- (specified by a typeface in that family) or by a familyName and a
- requested style.
- 1) If familyFace is null, use familyName.
- 2) If familyName is null, use data (UTF-16 to cover).
- 3) If all are null, return the default font that best matches style
- */
- static SkTypeface* CreateTypeface(const SkTypeface* familyFace,
- const char familyName[],
- SkTypeface::Style style);
-
- /** Return a new typeface given the data buffer. If the data does not
- represent a valid font, returns null.
-
- If a typeface instance is returned, the caller is responsible for
- calling unref() on the typeface when they are finished with it.
-
- The returned typeface may or may not have called ref() on the stream
- parameter. If the typeface has not called ref(), then it may have made
- a copy of the releveant data. In either case, the caller is still
- responsible for its refcnt ownership of the stream.
- */
- static SkTypeface* CreateTypefaceFromStream(SkStream*);
-
- /** Return a new typeface from the specified file path. If the file does not
- represent a valid font, this returns null. If a typeface is returned,
- the caller is responsible for calling unref() when it is no longer used.
- */
- static SkTypeface* CreateTypefaceFromFile(const char path[]);
-
- ///////////////////////////////////////////////////////////////////////////
-
- friend class SkScalerContext;
- friend class SkTypeface;
};
#endif
« no previous file with comments | « no previous file | src/core/SkFontHost.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698