Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 105223006: Remove a layer of indirection and code from SkFontHost. (Closed)

Created:
7 years ago by bungeman-skia
Modified:
6 years, 3 months ago
Reviewers:
mtklein, djsollen, tomhudson
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove a layer of indirection and code from SkFontHost. Committed: https://skia.googlesource.com/skia/+/f91c47d91d72a1d85e2d6701864b8d7accc81647

Patch Set 1 #

Patch Set 2 : Rebase, should now work due to Android changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -72 lines) Patch
M include/core/SkFontHost.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
M src/core/SkFontHost.cpp View 1 1 chunk +0 lines, -30 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 4 chunks +18 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
bungeman-skia
Now that Android is on SkFontMgr this can finally land. This essentially moves the implementation ...
6 years, 3 months ago (2014-09-10 22:05:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/105223006/20001
6 years, 3 months ago (2014-09-10 22:11:58 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-10 22:11:59 UTC) #5
commit-bot: I haz the power
Presubmit check for 105223006-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-09-10 22:12:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/105223006/20001
6 years, 3 months ago (2014-09-10 22:42:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f91c47d91d72a1d85e2d6701864b8d7accc81647
6 years, 3 months ago (2014-09-10 22:49:55 UTC) #11
bungeman-skia
On 2014/09/10 22:49:55, I haz the power (commit-bot) wrote: > Committed patchset #2 (id:20001) as ...
6 years, 3 months ago (2014-09-10 22:55:33 UTC) #12
mtklein
lgtm
6 years, 3 months ago (2014-09-10 23:30:40 UTC) #13
tomhudson
6 years, 3 months ago (2014-09-11 12:16:31 UTC) #14
Message was sent while issue was closed.
Moot LGTM.
Any chance of getting rid of legacyCreateTypeface() too?

Powered by Google App Engine
This is Rietveld 408576698