Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1052223008: Shutdown RenderWidgetHost owned by RenderFrameHost when destroying the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index b7b4ee8e8e403cd8e248ae9e7682780fbd36a081..0c167d494cc99b5a6fb9e29a9bd0044226886148 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -149,6 +149,7 @@ RenderFrameHostImpl::RenderFrameHostImpl(SiteInstance* site_instance,
render_frame_proxy_host_(NULL),
frame_tree_(frame_tree),
frame_tree_node_(frame_tree_node),
+ render_widget_host_(nullptr),
routing_id_(routing_id),
render_frame_created_(false),
navigations_suspended_(false),
@@ -180,8 +181,8 @@ RenderFrameHostImpl::RenderFrameHostImpl(SiteInstance* site_instance,
&RenderFrameHostImpl::OnSwappedOut, weak_ptr_factory_.GetWeakPtr())));
if (flags & CREATE_RF_NEEDS_RENDER_WIDGET_HOST) {
- render_widget_host_.reset(new RenderWidgetHostImpl(
- rwh_delegate, GetProcess(), MSG_ROUTING_NONE, hidden));
+ render_widget_host_ = new RenderWidgetHostImpl(rwh_delegate, GetProcess(),
+ MSG_ROUTING_NONE, hidden);
render_widget_host_->set_owned_by_render_frame_host(true);
}
}
@@ -214,7 +215,7 @@ RenderFrameHostImpl::~RenderFrameHostImpl() {
}
if (render_widget_host_)
- render_widget_host_->Cleanup();
+ render_widget_host_->Shutdown();
kenrb 2015/04/23 21:39:18 Worthwhile to add a comment that the RenderWidgetH
lfg 2015/04/23 22:19:54 Done.
}
int RenderFrameHostImpl::GetRoutingID() {
@@ -596,7 +597,7 @@ bool RenderFrameHostImpl::CreateRenderFrame(int parent_routing_id,
// lifetime of the current RenderProcessHost for this RenderFrameHost.
if (render_widget_host_) {
RenderWidgetHostView* rwhv =
- new RenderWidgetHostViewChildFrame(render_widget_host_.get());
+ new RenderWidgetHostViewChildFrame(render_widget_host_);
rwhv->Hide();
}
@@ -871,7 +872,7 @@ void RenderFrameHostImpl::OnDidDropNavigation() {
RenderWidgetHostImpl* RenderFrameHostImpl::GetRenderWidgetHost() {
if (render_widget_host_)
- return render_widget_host_.get();
+ return render_widget_host_;
// TODO(kenrb): When RenderViewHost no longer inherits RenderWidgetHost,
// we can remove this fallback. Currently it is only used for the main
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698