Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 105213004: Added more libraries to instrumented libraries build list. (Closed)

Created:
7 years ago by alextaran1
Modified:
7 years ago
CC:
chromium-reviews
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Added more libraries to instrumented libraries build list. BUG=313751 R=glider@chromium.org TBR=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242093

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -47 lines) Patch
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 2 8 chunks +107 lines, -47 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alextaran1
Splitted build list into two lists, sorted list of libraries. Please take a look.
7 years ago (2013-12-18 15:29:02 UTC) #1
Alexander Potapenko
https://codereview.chromium.org/105213004/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/105213004/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp#newcode11 third_party/instrumented_libraries/instrumented_libraries.gyp:11: # the order to build them all. Please elaborate ...
7 years ago (2013-12-18 15:42:13 UTC) #2
alextaran1
Done. Please take a look. https://codereview.chromium.org/105213004/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp File third_party/instrumented_libraries/instrumented_libraries.gyp (right): https://codereview.chromium.org/105213004/diff/1/third_party/instrumented_libraries/instrumented_libraries.gyp#newcode11 third_party/instrumented_libraries/instrumented_libraries.gyp:11: # the order to ...
7 years ago (2013-12-18 16:15:00 UTC) #3
Alexander Potapenko
LGTM
7 years ago (2013-12-18 16:27:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alextaran@chromium.org/105213004/20001
7 years ago (2013-12-18 16:46:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=135916
7 years ago (2013-12-18 21:09:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alextaran@chromium.org/105213004/40001
7 years ago (2013-12-20 09:49:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alextaran@chromium.org/105213004/40001
7 years ago (2013-12-20 10:03:48 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-20 13:21:04 UTC) #9
Message was sent while issue was closed.
Change committed as 242093

Powered by Google App Engine
This is Rietveld 408576698