Prevent bookmarks bar toggling from decreasing window height to 0.

Prevent bookmarks bar toggling from decreasing window height to 0.

Toggling the bookmarks bar changes the height of the browser window
when viewing a regular web page but does not change its height when
viewing a NTP. As a result, it is possible for the browser window to
creep taller or shorter with the right sequence of steps. When the
browser window gets shorter, it's possible to decrease its height to
0.

This change does not address the difference in behavior between NTPs
and regular web pages with the bookmarks bar, but it prevents the
browser window from programmatically dropping below its min height.

Added a unit test, and also had to adjust a unit test that created browser
windows with a height < 200 (min height for a browser window is 272).

BUG=230400
TEST=Create a browser window, confirm that View -> Always Show Bookmarks
Bar is checked, navigate to www.google.com, resize the window to its
minimum height, choose View -> Always Show Bookmarks Bar - the browser
window's bookmarks bar should disappear, but the browser window's height
should not change.

Committed: https://crrev.com/3d0f62159e9655f42bbdb80dae29f0e2d40db0c9
Cr-Commit-Position: refs/heads/master@{#325267}

[shrike, 2015-04-14 22:04:00]

shrike@chromium.org changed reviewers:
+ avi@chromium.org

[shrike, 2015-04-14 23:44:34]

PTAL

[Avi (use Gerrit), 2015-04-15 04:27:26]

LGTM with nits.

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller.mm:844: NSSize minWindowSize =
[window minSize];
Might as well do

CGFloat minWindowHeight = [window minSize].height;

and use minWindowHeight everywhere.

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_unittest.mm (right):

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_unittest.mm:211: NSWindow
*cocoaWindow = browser->window()->GetNativeWindow();
space after *

(yeah, fix it elsewhere in the file too)

[shrike, 2015-04-15 17:01:34]

PTAL

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller.mm:844: NSSize minWindowSize =
[window minSize];
On 2015/04/15 04:27:26, Avi wrote:
> Might as well do
> 
> CGFloat minWindowHeight = [window minSize].height;
> 
> and use minWindowHeight everywhere.

Agreed.

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
File chrome/browser/ui/cocoa/browser_window_controller_unittest.mm (right):

https://codereview.chromium.org/1052123006/diff/1/chrome/browser/ui/cocoa/bro...
chrome/browser/ui/cocoa/browser_window_controller_unittest.mm:211: NSWindow
*cocoaWindow = browser->window()->GetNativeWindow();
On 2015/04/15 04:27:26, Avi wrote:
> space after *
> 
> (yeah, fix it elsewhere in the file too)

Sorry about that. Fixed it in other spots too.

[shrike, 2015-04-15 17:02:18]

Actually, I realize you said LGTM (with nits). I fixed the nits, so I will go
ahead and commit.

[shrike, 2015-04-15 17:02:35]

The CQ bit was checked by shrike@chromium.org

[shrike, 2015-04-15 17:02:35]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1052123006/#ps20001
(title: "Fix nits.")

[commit-bot: I haz the power, 2015-04-15 17:04:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052123006/20001

[commit-bot: I haz the power, 2015-04-15 17:43:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 17:44:04]

Patchset 2 (id:??) landed as
https://crrev.com/3d0f62159e9655f42bbdb80dae29f0e2d40db0c9
Cr-Commit-Position: refs/heads/master@{#325267}