Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1052123003: Adds null check for isHTMLTableCellElement for AX presentational Role. (Closed)

Created:
5 years, 8 months ago by je_julie(Not used)
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adds null check for isHTMLTableCellElement for AX presentational Role. Crash was reported due to the CL, 1039873002, and it was caused by missing null check and sending wrong type. This patch adds null check and change the parameter type. The related CL:crrev.com/1039873002 BUG=474409 R=dmazzoni Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193248

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/modules/accessibility/AXNodeObject.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
je_julie(Not used)
Hi Dominic, The crash happened because null check was missed. Because isHTMLTableCellElement is not auto ...
5 years, 8 months ago (2015-04-07 04:04:53 UTC) #2
dmazzoni
lgtm
5 years, 8 months ago (2015-04-07 05:36:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052123003/1
5 years, 8 months ago (2015-04-07 05:37:09 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 07:00:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193248

Powered by Google App Engine
This is Rietveld 408576698