Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 1052103005: Documents what ApplicationManager::Delegate do (Closed)

Created:
5 years, 8 months ago by sky
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Documents what ApplicationManager::Delegate do And renames one to better indicate what it is expected to do. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/70d52bc9323a077b1ce28afa1d12f69c129e13bd Cr-Commit-Position: refs/heads/master@{#326847}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : dont nuke #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -26 lines) Patch
M mojo/shell/application_manager/application_manager.h View 1 2 1 chunk +10 lines, -3 lines 0 comments Download
M mojo/shell/application_manager/application_manager.cc View 1 2 3 chunks +3 lines, -13 lines 0 comments Download
M mojo/shell/application_manager/application_manager_unittest.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M mojo/shell/context.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/context.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/shell/native_runner_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
5 years, 8 months ago (2015-04-24 16:22:58 UTC) #1
sky
Turns out we can't combine the two. Otherwise we wouldn't be able to set a ...
5 years, 8 months ago (2015-04-24 16:44:00 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 8 months ago (2015-04-24 18:20:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052103005/40001
5 years, 8 months ago (2015-04-24 18:25:24 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 18:44:29 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:45:20 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/70d52bc9323a077b1ce28afa1d12f69c129e13bd
Cr-Commit-Position: refs/heads/master@{#326847}

Powered by Google App Engine
This is Rietveld 408576698