Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1052103003: Update frame around SAML IdP pages to new GAIA style (Closed)

Created:
5 years, 8 months ago by bartfab (slow)
Modified:
5 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update frame around SAML IdP pages to new GAIA style This CL updates the window in which SAML IdP pages are shown to match the new GAIA style: * The window expands to the size requested in the mocks. * The header text is updated to match the mocks. * An "X" button is shown, as requested in the mocks. The CL updates the windows shown during login and enrollment. Both are bit-for-bit identical now. See the bug for screen shots. BUG=467167 TEST=Manual Committed: https://crrev.com/7c02446724730577cf687e904b116b20027eb558 Cr-Commit-Position: refs/heads/master@{#325409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -12 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.css View 5 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment_webview.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 5 chunks +22 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
bartfab (slow)
Hi Pavel, Could you take a look please?
5 years, 8 months ago (2015-04-15 11:53:48 UTC) #2
Nikita (slow)
Per discussion with Pavel, rebalancing his CL review load a bit. I'm taking this one.
5 years, 8 months ago (2015-04-15 14:41:21 UTC) #4
Nikita (slow)
lgtm
5 years, 8 months ago (2015-04-16 08:32:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052103003/1
5 years, 8 months ago (2015-04-16 09:13:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 09:42:56 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 09:43:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c02446724730577cf687e904b116b20027eb558
Cr-Commit-Position: refs/heads/master@{#325409}

Powered by Google App Engine
This is Rietveld 408576698