Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1399)

Unified Diff: android_webview/browser/browser_view_renderer_unittest.cc

Issue 1052103002: Revert of cc: Make scheduling be driven by vsync for android webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/browser_view_renderer_client.h ('k') | cc/output/begin_frame_args.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/browser_view_renderer_unittest.cc
diff --git a/android_webview/browser/browser_view_renderer_unittest.cc b/android_webview/browser/browser_view_renderer_unittest.cc
index 634e1f3390e9a4f377b0597293d88de861d09cd1..e4c6eac5e89705cc4493d1b4216aa04079fa7983 100644
--- a/android_webview/browser/browser_view_renderer_unittest.cc
+++ b/android_webview/browser/browser_view_renderer_unittest.cc
@@ -9,7 +9,13 @@
namespace android_webview {
class SmokeTest : public RenderingTest {
- void StartTest() override { browser_view_renderer_->PostInvalidate(); }
+ void StartTest() override {
+ browser_view_renderer_->SetContinuousInvalidate(true);
+ }
+
+ void WillOnDraw() override {
+ browser_view_renderer_->SetContinuousInvalidate(false);
+ }
void DidDrawOnRT(SharedRendererState* functor) override {
EndTest();
@@ -20,20 +26,25 @@
class ClearViewTest : public RenderingTest {
public:
- ClearViewTest() : on_draw_count_(0) {}
+ ClearViewTest() : on_draw_count_(0u) {}
void StartTest() override {
- browser_view_renderer_->PostInvalidate();
+ browser_view_renderer_->SetContinuousInvalidate(true);
browser_view_renderer_->ClearView();
}
+ void WillOnDraw() override {
+ on_draw_count_++;
+ if (on_draw_count_ == 2u) {
+ browser_view_renderer_->SetContinuousInvalidate(false);
+ }
+ }
+
void DidOnDraw(bool success) override {
- on_draw_count_++;
- if (on_draw_count_ == 1) {
+ if (on_draw_count_ == 1u) {
// First OnDraw should be skipped due to ClearView.
EXPECT_FALSE(success);
browser_view_renderer_->DidUpdateContent(); // Unset ClearView.
- browser_view_renderer_->PostInvalidate();
} else {
// Following OnDraws should succeed.
EXPECT_TRUE(success);
@@ -44,23 +55,25 @@
EndTest();
}
private:
- int on_draw_count_;
+ size_t on_draw_count_;
};
RENDERING_TEST_F(ClearViewTest);
class TestAnimateInAndOutOfScreen : public RenderingTest {
public:
- TestAnimateInAndOutOfScreen() : on_draw_count_(0), draw_gl_count_on_rt_(0) {}
+ TestAnimateInAndOutOfScreen()
+ : on_draw_count_(0u), draw_gl_count_on_rt_(0u) {}
void StartTest() override {
new_constraints_ = ParentCompositorDrawConstraints(
false, gfx::Transform(), gfx::Rect(window_->surface_size()));
new_constraints_.transform.Scale(2.0, 2.0);
- browser_view_renderer_->PostInvalidate();
+ browser_view_renderer_->SetContinuousInvalidate(true);
}
void WillOnDraw() override {
+ browser_view_renderer_->SetContinuousInvalidate(false);
// Step 0: A single onDraw on screen. The parent draw constraints
// of the BVR will updated to be the initial constraints.
// Step 1: A single onDrraw off screen. The parent draw constraints of the
@@ -68,7 +81,7 @@
// Step 2: This onDraw is to introduce the DrawGL that animates the
// webview onto the screen on render thread. End the test when the parent
// draw constraints of BVR is updated to initial constraints.
- if (on_draw_count_ == 1 || on_draw_count_ == 2)
+ if (on_draw_count_ == 1u || on_draw_count_ == 2u)
browser_view_renderer_->PrepareToDraw(gfx::Vector2d(), gfx::Rect());
}
@@ -79,7 +92,7 @@
bool WillDrawOnRT(SharedRendererState* functor,
AwDrawGLInfo* draw_info) override {
- if (draw_gl_count_on_rt_ == 1) {
+ if (draw_gl_count_on_rt_ == 1u) {
draw_gl_count_on_rt_++;
ui_proxy_->PostTask(FROM_HERE, base::Bind(&RenderingTest::PostInvalidate,
base::Unretained(this)));
@@ -91,7 +104,7 @@
draw_info->is_layer = false;
gfx::Transform transform;
- if (draw_gl_count_on_rt_ == 0)
+ if (draw_gl_count_on_rt_ == 0u)
transform = new_constraints_.transform;
transform.matrix().asColMajorf(draw_info->transform);
@@ -132,8 +145,8 @@
}
private:
- int on_draw_count_;
- int draw_gl_count_on_rt_;
+ size_t on_draw_count_;
+ size_t draw_gl_count_on_rt_;
ParentCompositorDrawConstraints initial_constraints_;
ParentCompositorDrawConstraints new_constraints_;
};
« no previous file with comments | « android_webview/browser/browser_view_renderer_client.h ('k') | cc/output/begin_frame_args.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698