Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1052083004: pass legal premul values to bitmap -- do we still need this GM? (Closed)

Created:
5 years, 8 months ago by reed2
Modified:
5 years, 8 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

pass legal premul values to bitmap -- do we still need this GM? BUG=skia: Committed: https://skia.googlesource.com/skia/+/c6e13d73426624275db18a39bc5cf5322bf612a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gm/bitmaprect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
reed2
ptal
5 years, 8 months ago (2015-04-02 02:59:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052083004/1
5 years, 8 months ago (2015-04-02 02:59:36 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-02 02:59:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052083004/1
5 years, 8 months ago (2015-04-02 11:48:55 UTC) #8
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-02 11:54:53 UTC) #10
robertphillips
lgtm
5 years, 8 months ago (2015-04-02 12:41:04 UTC) #11
robertphillips
On 2015/04/02 12:41:04, robertphillips wrote: > lgtm I believe that particular GM (bigbitmaprect) is still ...
5 years, 8 months ago (2015-04-02 12:42:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1052083004/1
5 years, 8 months ago (2015-04-02 12:43:01 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 12:43:12 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c6e13d73426624275db18a39bc5cf5322bf612a8

Powered by Google App Engine
This is Rietveld 408576698