chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java - Issue 1052073002: Add icon to the overflow menu to trigger the page info popup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

Issue 1052073002: Add icon to the overflow menu to trigger the page info popup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/strings/android_chrome_strings.grd ('K') | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/android/shell/res/menu/main_menu.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

index f3cb500bf63c52e90cd3e7b5e80b21b56f4b3d25..c9cd2d4db736c8fd143e17d3e309775f37079958 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java

@@ -33,6 +33,7 @@ import org.chromium.chrome.browser.DevToolsServer;

import org.chromium.chrome.browser.FileProviderHelper;

import org.chromium.chrome.browser.ServiceTabLauncher;

import org.chromium.chrome.browser.Tab;

+import org.chromium.chrome.browser.WebsiteSettingsPopup;

import org.chromium.chrome.browser.appmenu.AppMenuHandler;

import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;

import org.chromium.chrome.browser.dom_distiller.DomDistillerTabUtils;

@@ -390,6 +391,9 @@ public class ChromeShellActivity extends ActionBarActivity implements AppMenuPro

activeTab.goForward();

}

return true;

+ } else if (id == R.id.info_menu_id) {

+ WebsiteSettingsPopup.show(this, activeTab.getProfile(), activeTab.getWebContents());

+ return true;

} else if (id == R.id.new_tab_menu_id) {

mTabManager.createNewTab();

return true;