Add icon to the overflow menu to trigger the page info popup

Add icon to the overflow menu to trigger the page info popup

The icon appears at the right of the top row of icons.

BUG=469996
Committed: https://crrev.com/308012eb5e60f9d16b35b03b562e1f6593647261
Cr-Commit-Position: refs/heads/master@{#324014}

[tsergeant, 2015-04-01 22:56:58]

tsergeant@chromium.org changed reviewers:
+ tedchoc@chromium.org

[tsergeant, 2015-04-01 22:56:59]

tedchoc@, can you please review?

I was going to hold off on this one until after animations had landed, but we
decided it was better to try and get the icon in for M43.

Corresponding internal change is at
https://chrome-internal-review.googlesource.com/#/c/211445/

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
(right):

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:45:
private static final int FOUR_BUTTON_MENU_ITEM = 2;
Is it suitable to just s/Three/Four like I've done here? I don't really see any
need to generalise it.

[Ted C, 2015-04-06 21:23:25]

lgtm

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
(right):

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java:45:
private static final int FOUR_BUTTON_MENU_ITEM = 2;
On 2015/04/01 22:56:58, tsergeant wrote:
> Is it suitable to just s/Three/Four like I've done here? I don't really see
any
> need to generalise it.

Yeah, that is fine.

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1098: <message
name="IDS_ACCESSIBILITY_MENU_INFO" desc="Content description for the button
which opens the page info popup">
maybe we should further describe what could be in this popup to help translators
do something better here.

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1099: View page info
The desktop string is:

"""
View site information
"""

Any reason to differ?

[tsergeant, 2015-04-07 03:39:22]

Thanks for reviewing

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/strings...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1098: <message
name="IDS_ACCESSIBILITY_MENU_INFO" desc="Content description for the button
which opens the page info popup">
On 2015/04/06 21:23:25, Ted C wrote:
> maybe we should further describe what could be in this popup to help
translators
> do something better here.

Done.

https://codereview.chromium.org/1052073002/diff/1/chrome/android/java/strings...
chrome/android/java/strings/android_chrome_strings.grd:1099: View page info
On 2015/04/06 21:23:25, Ted C wrote:
> The desktop string is:
> 
> """
> View site information
> """
> 
> Any reason to differ?

Done.

[tsergeant, 2015-04-07 03:39:39]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2015-04-07 03:39:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1052073002/#ps20001
(title: "Tweak strings")

[commit-bot: I haz the power, 2015-04-07 03:39:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1052073002/20001

[commit-bot: I haz the power, 2015-04-07 04:11:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-07 04:12:05]

Patchset 2 (id:??) landed as
https://crrev.com/308012eb5e60f9d16b35b03b562e1f6593647261
Cr-Commit-Position: refs/heads/master@{#324014}