Support custom path of blink_gc_plugin for distributed builds.

tools/clang/scripts/blink_gc_plugin_flags.sh

Index: tools/clang/scripts/blink_gc_plugin_flags.sh
diff --git a/tools/clang/scripts/blink_gc_plugin_flags.sh b/tools/clang/scripts/blink_gc_plugin_flags.sh
index 38ea72d695807e8649c3bab696597c1a1545ca12..27ff8796beb3be0c7c10c25ad0223f9b6c60549a 100755
--- a/tools/clang/scripts/blink_gc_plugin_flags.sh
+++ b/tools/clang/scripts/blink_gc_plugin_flags.sh
@@ -25,6 +25,8 @@ for arg in "$@"; do
     FLAGS="$FLAGS $PREFIX warn-raw-ptr"
   elif [[ "$arg" = "warn-unneeded-finalizer=1" ]]; then
     FLAGS="$FLAGS $PREFIX warn-unneeded-finalizer"
+  elif [[ "$arg" = custom_clang_lib_path=* ]]; then
+    CLANG_LIB_PATH="$(cd ${arg#*=} && echo $PWD)"

[hans, 2015/04/15 09:33:42]

Why bash is rusty. What does ${arg#*=} do?

[wjywbs, 2015/04/15 15:23:29]

If arg="custom_clang_lib_path=/tmp/llvm", then "${arg#*=}" will be "/tmp/llvm".

[hans, 2015/04/15 15:36:09]

Thanks.

What about quotes? In the "$arg" = test above, should the right-hand side be
quoted?

On line 29, the cd command will probably not work if the path has spaces, since
${arg#*=} is not quoted. Maybe that should be assigned to a variable first?

[wjywbs, 2015/04/16 02:20:41]

I tried that quoted string was for exact match, and non-quoted string was for
pattern matching.

I quoted ${arg#*=} and the echo line below for path with spaces.

   fi
 done