Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 10520020: [Chromoting] Update Keystone to 1.1.0.3659 and enable Packages. (Closed)

Created:
8 years, 6 months ago by garykac
Modified:
8 years, 6 months ago
Reviewers:
Mark Mentovai, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Update Keystone to 1.1.0.3659 and enable Packages. Update to the version of Keystone (Google Software Update) that is compatible with Mac OS 10.8. Start using Packages to build our installer. A follow-up CL will start signing this installer .mpkg. BUG=127267, 128629 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140615

Patch Set 1 #

Patch Set 2 : Add missing Keystone binary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A remoting/host/installer/mac/Keystone/GoogleSoftwareUpdate.pkg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D remoting/host/installer/mac/Keystone/GoogleSoftwareUpdate.pkg.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/host/installer/mac/do_signing.sh View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
garykac
8 years, 6 months ago (2012-06-05 01:12:17 UTC) #1
Jamie
lgtm
8 years, 6 months ago (2012-06-05 03:52:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/10520020/2001
8 years, 6 months ago (2012-06-05 16:11:30 UTC) #3
commit-bot: I haz the power
Try job failure for 10520020-2001 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=30144 Step "update" is always ...
8 years, 6 months ago (2012-06-05 16:13:14 UTC) #4
Mark Mentovai
8 years, 6 months ago (2012-06-06 19:52:56 UTC) #5
This is causing apparent Pulse sign failures:

.../pulse_build: running the chromoting script...
Signing .../org.chromium.chromoting.me2me_host.app
.../org.chromium.chromoting.me2me_host.app: signed bundle with Mach-O thin
(i386) [com.google.chrome_remote_desktop.remoting_me2me_host]
Signing .../Chrome Remote Desktop Host Uninstaller.app
.../Chrome Remote Desktop Host Uninstaller.app: signed bundle with Mach-O thin
(i386) [com.google.chromeremotedesktop.host_uninstaller]
Building .pkg from .../ChromotingHostService.pkgproj
.../do_signing.sh: line 126: packagesbuild: command not found

Is this expected?

Powered by Google App Engine
This is Rietveld 408576698