Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 1051983002: Add recordCount100Histogram() & recordSparseSlowlyHistogram() to RecordHistogram (Closed)

Created:
5 years, 8 months ago by pkotwicz
Modified:
5 years, 8 months ago
Reviewers:
Yaron, Ilya Sherman
CC:
chromium-reviews, erikwright+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add recordCount100Histogram() & recordSparseSlowlyHistogram() to RecordHistogram This should allow the remaining Java histogram logging code to be switched to RecordHistogram. BUG=428903 Committed: https://crrev.com/5aab443044c0e68467d4fdad07eb98b8b63fc51f Cr-Commit-Position: refs/heads/master@{#323685}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -24 lines) Patch
M base/android/java/src/org/chromium/base/metrics/RecordHistogram.java View 1 3 chunks +41 lines, -4 lines 0 comments Download
M base/android/record_histogram.cc View 3 chunks +50 lines, -20 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pkotwicz
yfriedman@ PTAL
5 years, 8 months ago (2015-04-01 20:17:54 UTC) #4
pkotwicz
yfriedman@ PTAL
5 years, 8 months ago (2015-04-01 20:17:55 UTC) #5
Yaron
lgtm but +isherman (metrics OWNER) for sanity
5 years, 8 months ago (2015-04-01 20:58:21 UTC) #7
Ilya Sherman
LGTM https://codereview.chromium.org/1051983002/diff/20001/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java File base/android/java/src/org/chromium/base/metrics/RecordHistogram.java (right): https://codereview.chromium.org/1051983002/diff/20001/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java#newcode59 base/android/java/src/org/chromium/base/metrics/RecordHistogram.java:59: * @param sample sample to be recorded, at ...
5 years, 8 months ago (2015-04-01 21:14:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051983002/40001
5 years, 8 months ago (2015-04-03 00:54:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-03 08:01:12 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:35:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5aab443044c0e68467d4fdad07eb98b8b63fc51f
Cr-Commit-Position: refs/heads/master@{#323685}

Powered by Google App Engine
This is Rietveld 408576698