Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1051973002: Test SkCodec to kIndex8 in nanobench. (Closed)

Created:
5 years, 8 months ago by scroggo
Modified:
5 years, 8 months ago
Reviewers:
msarett, mtklein, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Stop using SkBitmap when I do not need it. #

Patch Set 3 : Remove extra newline. #

Total comments: 2

Patch Set 4 : Rebase just in case. #

Patch Set 5 : fStorage -> fPixelStorage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -28 lines) Patch
M bench/CodecBench.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M bench/CodecBench.cpp View 1 2 3 4 1 chunk +17 lines, -3 lines 0 comments Download
M bench/DecodingBench.h View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M bench/DecodingBench.cpp View 1 2 3 4 2 chunks +16 lines, -15 lines 0 comments Download
M bench/nanobench.cpp View 1 2 3 2 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
scroggo
5 years, 8 months ago (2015-04-01 21:54:05 UTC) #2
scroggo
5 years, 8 months ago (2015-04-01 21:54:15 UTC) #4
msarett
lgtm https://codereview.chromium.org/1051973002/diff/40001/bench/CodecBench.h File bench/CodecBench.h (right): https://codereview.chromium.org/1051973002/diff/40001/bench/CodecBench.h#newcode36 bench/CodecBench.h:36: SkAutoMalloc fStorage; It wasn't completely clear to me ...
5 years, 8 months ago (2015-04-02 14:40:57 UTC) #5
scroggo
https://codereview.chromium.org/1051973002/diff/40001/bench/CodecBench.h File bench/CodecBench.h (right): https://codereview.chromium.org/1051973002/diff/40001/bench/CodecBench.h#newcode36 bench/CodecBench.h:36: SkAutoMalloc fStorage; On 2015/04/02 14:40:57, msarett wrote: > It ...
5 years, 8 months ago (2015-04-02 20:15:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051973002/80001
5 years, 8 months ago (2015-04-02 20:15:55 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 20:22:43 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/21027994192f395bbd1507558b84f59b3c7cf0da

Powered by Google App Engine
This is Rietveld 408576698