Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1051953003: Revert of [MacViews] Implement size constraints for app windows. (Closed)

Created:
5 years, 8 months ago by jackhou1
Modified:
5 years, 8 months ago
Reviewers:
tapted, Nico
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [MacViews] Implement size constraints for app windows. (patchset #9 id:160001 of https://codereview.chromium.org/1023083002/) Reason for revert: Broke GN build: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/6200 Original issue's description: > [MacViews] Implement size constraints for app windows. > > This works the same way as NativeAppWindowCocoa by setting > properties on the NSWindow in OnSizeConstraintsChanged. > > This also moves some code in common with NativeAppWindowCocoa > out to c/b/ui/cocoa/apps/nswindow_util.h. More code will be moved > there as they're implemented on MacViews, e.g. > CalculateDraggableRegions. > > BUG=459877 TBR=tapted@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459877 Committed: https://crrev.com/cc9931870450252a8c84d08f7c671a0a695a266c Cr-Commit-Position: refs/heads/master@{#323378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -255 lines) Patch
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 5 chunks +38 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_mac.mm View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/views/apps/native_app_window_frame_view_mac.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/views/apps/native_app_window_frame_view_mac.mm View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gfx/mac/nswindow_frame_controls.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/gfx/mac/nswindow_frame_controls.mm View 1 chunk +0 lines, -63 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 3 chunks +0 lines, -18 lines 0 comments Download
M ui/views/widget/native_widget_mac.mm View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jackhou1
Created Revert of [MacViews] Implement size constraints for app windows.
5 years, 8 months ago (2015-04-02 00:35:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051953003/1
5 years, 8 months ago (2015-04-02 00:36:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 00:38:06 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:20:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc9931870450252a8c84d08f7c671a0a695a266c
Cr-Commit-Position: refs/heads/master@{#323378}

Powered by Google App Engine
This is Rietveld 408576698