Split SdchManager::Dictionary out into separate class/file.

Split SdchManager::Dictionary out into separate class/file.

BUG=None
R=ellyjones@chromium.org

Committed: https://crrev.com/75b351925587d681a4438d410c2af91d174d7864
Cr-Commit-Position: refs/heads/master@{#324333}

[Randy Smith (Not in Mondays), 2015-04-01 20:52:16]

Elly: As part of doing the load-on-demand work, I decided to make
SdchManager::Dictionary private to SdchManager, and as part of that I tripped
over some difficulties in making the declarations within the SdchManager class
fit the "public, then private" rule.  So I decided to cut the Gordion knot and
just pull Dictionary out of SdchManager.  PTAL?

Matt: You're cc'd FYI because it's a refactoring CL and you might have interest,
but you're welcome to review or not as you wish.

There will be a follow-on refactoring CL coming soon that removes SdchDictionary
from the SdchManager interface (preparatory to expanding it to include
callback-based storage).

[Elly Fong-Jones, 2015-04-08 16:25:34]

lgtm

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_dictionar...
File net/base/sdch_dictionary.cc (right):

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_dictionar...
net/base/sdch_dictionary.cc:151: */
indentation

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_manager.cc
File net/base/sdch_manager.cc (right):

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_manager.c...
net/base/sdch_manager.cc:272: if (!secure_scheme_supported() &&
target_url.SchemeIsSecure())
Is this an unrelated bugfix?

[Randy Smith (Not in Mondays), 2015-04-08 21:06:05]

Incorporated comments.  I went a bit beyond what you suggested and reformatted
all the 1.,2.,3. comments in sdch_dictionary.cc, but as it's just comment
reformatting, I'm not going to ask for a re-review.  But if you have further
comments, I'd be happy to follow with a chaser CL.  Thanks!

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_dictionar...
File net/base/sdch_dictionary.cc (right):

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_dictionar...
net/base/sdch_dictionary.cc:151: */
On 2015/04/08 16:25:33, Elly Jones wrote:
> indentation

Reformatted to use /*\n*...\n*...\n*/ style.  Did the same to all other comments
of this style in the file.

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_manager.cc
File net/base/sdch_manager.cc (right):

https://codereview.chromium.org/1051933002/diff/20001/net/base/sdch_manager.c...
net/base/sdch_manager.cc:272: if (!secure_scheme_supported() &&
target_url.SchemeIsSecure())
On 2015/04/08 16:25:33, Elly Jones wrote:
> Is this an unrelated bugfix?

Not really.  CanUse() used to use the above test, but copying that directly into
SdchDictionary mean that SdchManager depends on SdchDictionary depends on
SdchManager.  Pulling the check up into GetDictionarySet() allows breaking that
dependency loop.

[Randy Smith (Not in Mondays), 2015-04-08 21:06:13]

The CQ bit was checked by rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2015-04-08 21:06:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/1051933002/#ps40001
(title: "Incorporated comments.")

[commit-bot: I haz the power, 2015-04-08 21:08:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1051933002/40001

[commit-bot: I haz the power, 2015-04-09 01:30:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-09 01:32:24]

Patchset 3 (id:??) landed as
https://crrev.com/75b351925587d681a4438d410c2af91d174d7864
Cr-Commit-Position: refs/heads/master@{#324333}