Issue 1051913002: [Effen] use the fact that the parent knows its depth already to avoid walking the entire tree each …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051913002: [Effen] use the fact that the parent knows its depth already to avoid walking the entire tree each … (Closed)

Created:
5 years, 8 months ago by Hixie

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] use the fact that the parent knows its depth already to avoid walking the entire tree each time, and simplify how we build the trace message R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1253462d3a69c846906643a2cc9e5dfd86003c9a

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -14 lines)			Patch
	M	sky/framework/fn.dart	View		3 chunks	+4 lines, -14 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 8 months ago (2015-04-01 17:30:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1253462d3a69c846906643a2cc9e5dfd86003c9a (presubmit successful).