Source/modules/webmidi/MIDIInput.h - Issue 1051903002: Web MIDI: implement implicit open() on send() and setOnmidimessage()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIInput.h

Issue 1051903002: Web MIDI: implement implicit open() on send() and setOnmidimessage() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIInput.h

diff --git a/Source/modules/webmidi/MIDIInput.h b/Source/modules/webmidi/MIDIInput.h

index 635f4cb0368180d585a6fc7a264862f66d5fe60a..6ff64e872febdb8a608053ab343ebe534b9af59f 100644

--- a/Source/modules/webmidi/MIDIInput.h

+++ b/Source/modules/webmidi/MIDIInput.h

@@ -45,7 +45,7 @@ public:

static MIDIInput* create(MIDIAccess*, const String& id, const String& manufacturer, const String& name, const String& version, MIDIAccessor::MIDIPortState);

virtual ~MIDIInput() { }

- DEFINE_ATTRIBUTE_EVENT_LISTENER(midimessage);

+ DECLARE_FORWARDING_ATTRIBUTE_EVENT_LISTENER(, midimessage);

Takashi Toyoshima 2015/04/01 16:32:34 It looks there were no users of this macro, and I'

// EventTarget

virtual const AtomicString& interfaceName() const override { return EventTargetNames::MIDIInput; }

« LayoutTests/webmidi/state-check-utils.js ('K') | « LayoutTests/webmidi/state-check-utils.js ('k') | Source/modules/webmidi/MIDIInput.cpp » ('j') | Source/modules/webmidi/MIDIPort.h » ('J')