Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: Source/modules/webmidi/MIDIInput.cpp

Issue 1051903002: Web MIDI: implement implicit open() on send() and setOnmidimessage() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: kouhei review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/webmidi/MIDIInput.h ('k') | Source/modules/webmidi/MIDIOutput.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 { 43 {
44 ASSERT(access); 44 ASSERT(access);
45 return new MIDIInput(access, id, manufacturer, name, version, state); 45 return new MIDIInput(access, id, manufacturer, name, version, state);
46 } 46 }
47 47
48 MIDIInput::MIDIInput(MIDIAccess* access, const String& id, const String& manufac turer, const String& name, const String& version, PortState state) 48 MIDIInput::MIDIInput(MIDIAccess* access, const String& id, const String& manufac turer, const String& name, const String& version, PortState state)
49 : MIDIPort(access, id, manufacturer, name, TypeInput, version, state) 49 : MIDIPort(access, id, manufacturer, name, TypeInput, version, state)
50 { 50 {
51 } 51 }
52 52
53 EventListener* MIDIInput::onmidimessage()
54 {
55 return getAttributeEventListener(EventTypeNames::midimessage);
56 }
57
58 void MIDIInput::setOnmidimessage(PassRefPtr<EventListener> listener)
59 {
60 // Implicit open. It does nothing if the port is already opened.
61 // See http://www.w3.org/TR/webmidi/#widl-MIDIPort-open-Promise-MIDIPort
62 open();
63
64 setAttributeEventListener(EventTypeNames::midimessage, listener);
65 }
66
53 void MIDIInput::didReceiveMIDIData(unsigned portIndex, const unsigned char* data , size_t length, double timeStamp) 67 void MIDIInput::didReceiveMIDIData(unsigned portIndex, const unsigned char* data , size_t length, double timeStamp)
54 { 68 {
55 ASSERT(isMainThread()); 69 ASSERT(isMainThread());
56 70
57 if (!length) 71 if (!length)
58 return; 72 return;
59 73
74 if (getConnection() != ConnectionStateOpen)
75 return;
76
60 // Drop sysex message here when the client does not request it. Note that th is is not a security check but an 77 // Drop sysex message here when the client does not request it. Note that th is is not a security check but an
61 // automatic filtering for clients that do not want sysex message. Also note that sysex message will never be sent 78 // automatic filtering for clients that do not want sysex message. Also note that sysex message will never be sent
62 // unless the current process has an explicit permission to handle sysex mes sage. 79 // unless the current process has an explicit permission to handle sysex mes sage.
63 if (data[0] == 0xf0 && !midiAccess()->sysexEnabled()) 80 if (data[0] == 0xf0 && !midiAccess()->sysexEnabled())
64 return; 81 return;
65 RefPtr<DOMUint8Array> array = DOMUint8Array::create(data, length); 82 RefPtr<DOMUint8Array> array = DOMUint8Array::create(data, length);
66 dispatchEvent(MIDIMessageEvent::create(timeStamp, array)); 83 dispatchEvent(MIDIMessageEvent::create(timeStamp, array));
67 } 84 }
68 85
69 DEFINE_TRACE(MIDIInput) 86 DEFINE_TRACE(MIDIInput)
70 { 87 {
71 MIDIPort::trace(visitor); 88 MIDIPort::trace(visitor);
72 } 89 }
73 90
74 } // namespace blink 91 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/webmidi/MIDIInput.h ('k') | Source/modules/webmidi/MIDIOutput.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698