Web MIDI: implement implicit open() on send() and setOnmidimessage()

Source/modules/webmidi/MIDIPort.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 58 matching lines @@
 
     DECLARE_VIRTUAL_TRACE();
 
     DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);
 
     // EventTarget
     virtual const AtomicString& interfaceName() const override { return EventTargetNames::MIDIPort; }
     virtual ExecutionContext* executionContext() const override final;
 
 protected:
-    MIDIPort(MIDIAccess*, const String& id, const String& manufacturer, const String& name, TypeCode, const String& version, MIDIAccessor::MIDIPortState);
-
-private:
     enum ConnectionState {
         ConnectionStateOpen,
         ConnectionStateClosed,
         ConnectionStatePending
     };
 
+    MIDIPort(MIDIAccess*, const String& id, const String& manufacturer, const String& name, TypeCode, const String& version, MIDIAccessor::MIDIPortState);
+    ConnectionState getConnection() const { return m_connection; }

[yhirano, 2015/04/02 02:15:10]

I think this function can be public.

[Takashi Toyoshima, 2015/04/02 04:03:21]

Done.

+
+    void open();
+
+private:
     ScriptPromise accept(ScriptState*);
     ScriptPromise reject(ScriptState*, ExceptionCode, const String& message);
 
     void setStates(MIDIAccessor::MIDIPortState, ConnectionState);
 
     String m_id;
     String m_manufacturer;
     String m_name;
     TypeCode m_type;
     String m_version;
     Member<MIDIAccess> m_access;
     MIDIAccessor::MIDIPortState m_state;
     ConnectionState m_connection;
 };
 
 } // namespace blink
 
 #endif // MIDIPort_h