Web MIDI: implement implicit open() on send() and setOnmidimessage()

Source/modules/webmidi/MIDIPort.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 79 matching lines @@
 {
     switch (m_type) {
     case TypeInput:
         return "input";
     case TypeOutput:
         return "output";
     }
     return emptyString();
 }
 
 ScriptPromise MIDIPort::open(ScriptState* scriptState)

[yhirano, 2015/04/02 02:15:10]

Why do you need this function? Isn't it enough to drop [CallWith=ScriptState]
from the IDL?

[Takashi Toyoshima, 2015/04/02 04:03:21]

ScriptState is still needed to return Promise at line 103.

[yhirano, 2015/04/02 04:13:00]

Sorry, I overlooked that.

 {
-    if (m_connection == ConnectionStateClosed) {
-        switch (m_state) {
-        case PortState::MIDIPortStateDisconnected:
-            setStates(m_state, ConnectionStatePending);
-            break;
-        case PortState::MIDIPortStateConnected:
-            // TODO(toyoshim): Add blink API to perform a real open and close
-            // operation.
-            setStates(m_state, ConnectionStateOpen);
-            break;
-        case PortState::MIDIPortStateOpened:
-            // TODO(toyoshim): Remove PortState::MIDIPortStateOpened.
-            ASSERT_NOT_REACHED();
-            break;
-        }
-    }
+    open();
     return accept(scriptState);
 }
 
 ScriptPromise MIDIPort::close(ScriptState* scriptState)
 {
     if (m_connection != ConnectionStateClosed) {
         // TODO(toyoshim): Do clear() operation on MIDIOutput.
         // TODO(toyoshim): Add blink API to perform a real close operation.
         setStates(m_state, ConnectionStateClosed);
     }
     return accept(scriptState);
 }
 
 void MIDIPort::setState(PortState state)
 {
     setStates(state, m_connection);
 }
 
 ExecutionContext* MIDIPort::executionContext() const
 {
     return m_access->executionContext();
 }
 
 DEFINE_TRACE(MIDIPort)
 {
     visitor->trace(m_access);
     RefCountedGarbageCollectedEventTargetWithInlineData<MIDIPort>::trace(visitor);
 }
 
+void MIDIPort::open()
+{
+    if (m_connection == ConnectionStateClosed) {
+        switch (m_state) {
+        case PortState::MIDIPortStateDisconnected:
+            setStates(m_state, ConnectionStatePending);
+            break;
+        case PortState::MIDIPortStateConnected:
+            // TODO(toyoshim): Add blink API to perform a real open and close
+            // operation.
+            setStates(m_state, ConnectionStateOpen);
+            break;
+        case PortState::MIDIPortStateOpened:
+            // TODO(toyoshim): Remove PortState::MIDIPortStateOpened.
+            ASSERT_NOT_REACHED();
+            break;
+        }
+    }
+}
+
 ScriptPromise MIDIPort::accept(ScriptState* scriptState)
 {
     return ScriptPromise::cast(scriptState, toV8(this, scriptState->context()->Global(), scriptState->isolate()));
 }
 
 ScriptPromise MIDIPort::reject(ScriptState* scriptState, ExceptionCode ec, const String& message)
 {
     return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(ec, message));
 }
 
 void MIDIPort::setStates(PortState state, ConnectionState connection)
 {
     if (m_state == state && m_connection == connection)
         return;
     m_state = state;
     m_connection = connection;
     dispatchEvent(MIDIConnectionEvent::create(this));
     m_access->dispatchEvent(MIDIConnectionEvent::create(this));
 }
 
 } // namespace blink