Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: base/threading/platform_thread_win.cc

Issue 1051863003: Turn ThreadPriority enum into an enum class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@setthreadpri
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/platform_thread_win.cc
diff --git a/base/threading/platform_thread_win.cc b/base/threading/platform_thread_win.cc
index df44ec2c4770f5066c7ad5447e83d391a8577d11..b5cc49b3d17791c4fc395eb6b7f982688366ba7b 100644
--- a/base/threading/platform_thread_win.cc
+++ b/base/threading/platform_thread_win.cc
@@ -237,16 +237,16 @@ void PlatformThread::SetThreadPriority(PlatformThreadHandle handle,
int desired_priority = THREAD_PRIORITY_ERROR_RETURN;
switch (priority) {
rvargas (doing something else) 2015/04/01 19:10:35 nit: please reorder the switch order to follow the
gab 2015/04/01 21:05:33 Done.
- case kThreadPriority_Normal:
+ case ThreadPriority::NORMAL:
desired_priority = THREAD_PRIORITY_NORMAL;
break;
- case kThreadPriority_RealtimeAudio:
+ case ThreadPriority::REALTIMEAUDIO:
desired_priority = THREAD_PRIORITY_TIME_CRITICAL;
break;
- case kThreadPriority_Display:
+ case ThreadPriority::DISPLAY:
desired_priority = THREAD_PRIORITY_ABOVE_NORMAL;
break;
- case kThreadPriority_Background:
+ case ThreadPriority::BACKGROUND:
desired_priority = THREAD_PRIORITY_LOWEST;
break;
default:
@@ -270,18 +270,18 @@ ThreadPriority PlatformThread::GetThreadPriority(PlatformThreadHandle handle) {
int priority = ::GetThreadPriority(handle.handle_);
switch (priority) {
case THREAD_PRIORITY_NORMAL:
- return kThreadPriority_Normal;
+ return ThreadPriority::NORMAL;
case THREAD_PRIORITY_TIME_CRITICAL:
- return kThreadPriority_RealtimeAudio;
+ return ThreadPriority::REALTIMEAUDIO;
case THREAD_PRIORITY_ABOVE_NORMAL:
- return kThreadPriority_Display;
+ return ThreadPriority::DISPLAY;
case THREAD_PRIORITY_LOWEST:
- return kThreadPriority_Background;
+ return ThreadPriority::BACKGROUND;
case THREAD_PRIORITY_ERROR_RETURN:
DPCHECK(false) << "GetThreadPriority error"; // Falls through.
default:
NOTREACHED() << "Unexpected priority: " << priority;
- return kThreadPriority_Normal;
+ return ThreadPriority::NORMAL;
}
}

Powered by Google App Engine
This is Rietveld 408576698