Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1051833002: Reland: Fix JSON parser Handle leak (previous CL 1041483004) (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: Fix JSON parser Handle leak (previous CL 1041483004) R=mstarzinger@chromium.org BUG=v8:3976 BUG=472504 LOG=y Committed: https://crrev.com/5a93a3304cf3e32f7f49459ddb667bb2b8a4ae56 Cr-Commit-Position: refs/heads/master@{#27571}

Patch Set 1 #

Patch Set 2 : Fix handling of stack overflow #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -89 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +19 lines, -0 lines 0 comments Download
M src/json-parser.h View 1 5 chunks +130 lines, -83 lines 0 comments Download
M test/mjsunit/regress/regress-3976.js View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-472504.js View 1 1 chunk +4 lines, -5 lines 3 comments Download

Messages

Total messages: 14 (3 generated)
Erik Corry Chromium.org
5 years, 8 months ago (2015-04-01 14:48:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051833002/20001
5 years, 8 months ago (2015-04-01 14:54:03 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1684)
5 years, 8 months ago (2015-04-01 15:03:42 UTC) #5
Michael Starzinger
LGTM on patch set 2, didn't look at the rest. https://codereview.chromium.org/1051833002/diff/20001/test/mjsunit/regress/regress-472504.js File test/mjsunit/regress/regress-472504.js (right): https://codereview.chromium.org/1051833002/diff/20001/test/mjsunit/regress/regress-472504.js#newcode4 ...
5 years, 8 months ago (2015-04-01 16:18:11 UTC) #6
Michael Starzinger
Also the URL in the CL description is weird, can we drop the URL?
5 years, 8 months ago (2015-04-01 16:18:44 UTC) #7
Michael Starzinger
Also the URL in the CL description is weird, can we drop the URL?
5 years, 8 months ago (2015-04-01 16:18:46 UTC) #8
Erik Corry Chromium.org
https://codereview.chromium.org/1051833002/diff/20001/test/mjsunit/regress/regress-472504.js File test/mjsunit/regress/regress-472504.js (right): https://codereview.chromium.org/1051833002/diff/20001/test/mjsunit/regress/regress-472504.js#newcode4 test/mjsunit/regress/regress-472504.js:4: On 2015/04/01 16:18:11, Michael Starzinger wrote: > suggestion: I ...
5 years, 8 months ago (2015-04-01 16:55:24 UTC) #9
Michael Starzinger
https://codereview.chromium.org/1051833002/diff/20001/test/mjsunit/regress/regress-472504.js File test/mjsunit/regress/regress-472504.js (right): https://codereview.chromium.org/1051833002/diff/20001/test/mjsunit/regress/regress-472504.js#newcode4 test/mjsunit/regress/regress-472504.js:4: On 2015/04/01 16:55:24, Erik Corry Chromium.org wrote: > On ...
5 years, 8 months ago (2015-04-01 16:56:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051833002/20001
5 years, 8 months ago (2015-04-01 16:57:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-01 16:58:39 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 16:58:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a93a3304cf3e32f7f49459ddb667bb2b8a4ae56
Cr-Commit-Position: refs/heads/master@{#27571}

Powered by Google App Engine
This is Rietveld 408576698