Store GPU pixel test reference images outside source tree

Store GPU pixel test reference images outside source tree

Instead of keeping the Android GPU pixel test reference images inside
the source tree, store them under the top level build bot directory,
e.g.,
/b/build/slave/<slave_name>/build/content_gpu_data/telemetry/{gpu_reference,generated}

This matches the location used on the non-Android GPU bots.

This patch also gives the current SVN revision to the test runner so the
reference images will get updated correctly.

TBR=navabi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240338

[navabi, 2013-12-11 01:18:47]

I'm not familiar with the GPU bots.

I'm assuming besides the src directory, these bots checkout a build director
that has a content_gpu_data subdirectory (i.e.
/b/build/slave/<slave_name>/build/content_gpu_data/)? Where is the code that
checks this out? I didn't see it in the
build/masters/master.chromium.gpu/master.cfg.

Am I not looking hard enough?

[Sami, 2013-12-11 10:20:49]

On 2013/12/11 01:18:47, navabi wrote:
> I'm not familiar with the GPU bots.
> 
> I'm assuming besides the src directory, these bots checkout a build director
> that has a content_gpu_data subdirectory (i.e.
> /b/build/slave/<slave_name>/build/content_gpu_data/)? Where is the code that
> checks this out? I didn't see it in the
> build/masters/master.chromium.gpu/master.cfg.
> 
> Am I not looking hard enough?

Yes, you looked hard enough since that directory isn't actually getting checked
out :) Because the reference images are different on many of the bots (due to
different GPUs), what we do instead automatically generate the reference
pictures under content_gpu_data/ if that directory is missing. Then on further
runs we just compare against those reference images to check against
regressions. There's also a way to programmatically update the reference images
when the test changes.

All the other GPU bots already work like this and just Android is the odd one
out; see for example the flags for win7:

http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%...

[navabi, 2013-12-11 20:02:17]

On 2013/12/11 10:20:49, Sami wrote:
> On 2013/12/11 01:18:47, navabi wrote:
> > I'm not familiar with the GPU bots.
> > 
> > I'm assuming besides the src directory, these bots checkout a build director
> > that has a content_gpu_data subdirectory (i.e.
> > /b/build/slave/<slave_name>/build/content_gpu_data/)? Where is the code that
> > checks this out? I didn't see it in the
> > build/masters/master.chromium.gpu/master.cfg.
> > 
> > Am I not looking hard enough?
> 
> Yes, you looked hard enough since that directory isn't actually getting
checked
> out :) Because the reference images are different on many of the bots (due to
> different GPUs), what we do instead automatically generate the reference
> pictures under content_gpu_data/ if that directory is missing. Then on further
> runs we just compare against those reference images to check against
> regressions. There's also a way to programmatically update the reference
images
> when the test changes.
> 
> All the other GPU bots already work like this and just Android is the odd one
> out; see for example the flags for win7:
> 
>
http://build.chromium.org/p/chromium.gpu/builders/Win7%2520Release%2520%2528N...

Thanks for the explanation Sami. LGTM.

[commit-bot: I haz the power, 2013-12-12 10:36:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/105183002/1

[commit-bot: I haz the power, 2013-12-12 10:55:29]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sami, 2013-12-12 11:27:52]

Thanks Armand! I'll TBR this since I mistakenly added your @google.com address
for review.

[commit-bot: I haz the power, 2013-12-12 11:31:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skyostil@chromium.org/105183002/1

[commit-bot: I haz the power, 2013-12-12 17:06:04]

Change committed as 240338

[navabi1, 2013-12-13 01:19:03]

lgtm