Issue 1051813002: Revert of Fix startup_metric racing condition: It used to wait t.WaitForDocumentReadyStateToBeComplete() befo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051813002: Revert of Fix startup_metric racing condition: It used to wait t.WaitForDocumentReadyStateToBeComplete() befo… (Closed)

Created:
5 years, 8 months ago by dsinclair

Modified:
5 years, 8 months ago

Reviewers:
cylee1, nednguyen

CC:
chromium-reviews, telemetry-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix startup_metric racing condition: It used to wait t.WaitForDocumentReadyStateToBeComplete() befo… (patchset #2 id:20001 of https://codereview.chromium.org/1041213003/) Reason for revert: Causing test failures on several bots. See crbug.com/472603 Original issue's description: > 1. Use window.performance.timing instead of statsCollectionController to get page loading time. > 2. Fix waiting condition to avoid racing condition > > BUG=467964 > > Committed: https://crrev.com/91e201627c7dee41d085b1829b7a60daf9b9e601 > Cr-Commit-Position: refs/heads/master@{#323213} TBR=nednguyen@google.com,cylee@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467964 Committed: https://crrev.com/a26a404c0e04d0ecc091aeb8ca4755d35ed1565f Cr-Commit-Position: refs/heads/master@{#323233}

Created: 5 years, 8 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -7 lines)			Patch
	M	tools/perf/metrics/startup_metric.py	View		3 chunks	+19 lines, -7 lines	0 comments	Download

Total messages: 1 (0 generated)

dsinclair

5 years, 8 months ago (2015-04-01 14:04:45 UTC) #1

Created Revert of Fix startup_metric racing condition: It used to wait
t.WaitForDocumentReadyStateToBeComplete() befo…