Issue 1051763008: Windows GN component build fixes: gpu, gcm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051763008: Windows GN component build fixes: gpu, gcm (Closed)

Created:
5 years, 8 months ago by brettw

Modified:
5 years, 8 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, piman+watch_chromium.org, zea+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Windows GN component build fixes: gpu, gcm TBR=dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/45b7e2502461503f255d612e2cf46eec7a2a8f60 Cr-Commit-Position: refs/heads/master@{#326918}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	google_apis/gcm/BUILD.gn	View		4 chunks	+6 lines, -4 lines	0 comments	Download
	M	gpu/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

brettw

Split off of https://codereview.chromium.org/1071633003/, carrying review over.

5 years, 8 months ago (2015-04-24 21:47:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051763008/1

5 years, 8 months ago (2015-04-24 21:50:09 UTC) #3

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 22:58:59 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/45b7e2502461503f255d612e2cf46eec7a2a8f60
Cr-Commit-Position: refs/heads/master@{#326918}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages