Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/core/v8/V8Binding.h

Issue 1051753003: bindings: Add toBoolean() to V8Binding.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8Binding.h
diff --git a/Source/bindings/core/v8/V8Binding.h b/Source/bindings/core/v8/V8Binding.h
index 9b6b2fdf371356204a539ee315c72835bd7dab68..7e9915b356402e837f257dc17ea55344529d7888 100644
--- a/Source/bindings/core/v8/V8Binding.h
+++ b/Source/bindings/core/v8/V8Binding.h
@@ -387,6 +387,15 @@ enum IntegerConversionConfiguration {
Clamp
};
+// Convert a value to a boolean.
+bool toBooleanSlow(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
vivekg 2015/04/10 07:17:30 Should we export this symbol using CORE_EXPORT?
bashi 2015/04/10 07:25:20 Done.
+inline bool toBoolean(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
+{
+ if (LIKELY(value->IsBoolean()))
+ return value.As<v8::Boolean>()->Value();
+ return toBooleanSlow(isolate, value, exceptionState);
+}
+
// Convert a value to a 8-bit signed integer. The conversion fails if the
// value cannot be converted to a number or the range violated per WebIDL:
// http://www.w3.org/TR/WebIDL/#es-byte
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | Source/bindings/tests/results/core/V8TestDictionary.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698