Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 1051753003: bindings: Add toBoolean() to V8Binding.h (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
diff --git a/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp b/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
index 58c1edb1673155c2324d78c988c757f5c8061570..13f402d39bbc1bdf7e80ee1ce217dc319017f4e2 100644
--- a/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
+++ b/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp
@@ -30,7 +30,9 @@ void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Valu
if (booleanMemberValue.IsEmpty() || booleanMemberValue->IsUndefined()) {
// Do nothing.
} else {
- bool booleanMember = booleanMemberValue->BooleanValue();
+ bool booleanMember = toBoolean(isolate, booleanMemberValue, exceptionState);
+ if (exceptionState.hadException())
+ return;
impl.setBooleanMember(booleanMember);
}
« Source/bindings/core/v8/V8Binding.h ('K') | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698