bindings: Add toBoolean() to V8Binding.h

Source/bindings/core/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 369 matching lines @@
     return v8::Handle<v8::Value>();
 }
 
 // Conversion flags, used in toIntXX/toUIntXX.
 enum IntegerConversionConfiguration {
     NormalConversion,
     EnforceRange,
     Clamp
 };
 
+// Convert a value to a boolean.
+inline bool toBoolean(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState)
+{
+    if (value->IsBoolean())

[vivekg, 2015/04/10 05:43:47]

Shall we split this into fast (inline toBoolean) and slower (non-inline
toBooleanSlow) path as is the case with other conversions?

[vivekg, 2015/04/10 05:47:36]

Or may be wrap it using 

inline bool toBoolean(v8::Isolate* isolate, v8::Local<v8::Value> value,
ExceptionState& exceptionState)
{
    if (LIKELY(value->IsBoolean()))
        return value.As<v8::Boolean>()->Value();

    ...
}

[haraken, 2015/04/10 05:48:01]

Yeah, it's good to minimize the inlined part. We can move the TryCatch part into
.cpp.

[bashi, 2015/04/10 06:39:54]

Done.

+        return value.As<v8::Boolean>()->Value();
+    v8::TryCatch block;
+    bool result = false;
+    if (!v8Call(value->BooleanValue(isolate->GetCurrentContext()), result, block))
+        exceptionState.rethrowV8Exception(block.Exception());
+    return result;
+}
+
 // Convert a value to a 8-bit signed integer. The conversion fails if the
 // value cannot be converted to a number or the range violated per WebIDL:
 // http://www.w3.org/TR/WebIDL/#es-byte
 int8_t toInt8(v8::Isolate*, v8::Handle<v8::Value>, IntegerConversionConfiguration, ExceptionState&);
 
 // Convert a value to a 8-bit unsigned integer. The conversion fails if the
 // value cannot be converted to a number or the range violated per WebIDL:
 // http://www.w3.org/TR/WebIDL/#es-octet
 uint8_t toUInt8(v8::Isolate*, v8::Handle<v8::Value>, IntegerConversionConfiguration, ExceptionState&);
 
@@ skipping 590 matching lines @@
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(v8::Isolate*, ExecutionContext*, v8::Handle<v8::Function>);
 
 // Callback functions used by generated code.
 CORE_EXPORT void v8ConstructorAttributeGetter(v8::Local<v8::Name> propertyName, const v8::PropertyCallbackInfo<v8::Value>&);
 
 typedef void (*InstallTemplateFunction)(v8::Local<v8::FunctionTemplate>, v8::Isolate*);
 
 } // namespace blink
 
 #endif // V8Binding_h