Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 105173003: Update InfoBarUtil to use TouchCommon over TestTouchUtils. (Closed)

Created:
6 years, 12 months ago by Kibeom Kim (inactive)
Modified:
6 years, 11 months ago
Reviewers:
Yaron, Maria
CC:
chromium-reviews, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Update InfoBarUtil to use TouchCommon over TestTouchUtils. TouchCommon utils are preferable for test use because they work even if there is a crash dialog on the screen from a previous test. This makes the tests run more robustly. BUG=320084 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarUtil.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Kibeom Kim (inactive)
Maria: Is this a correct way to fix? I saw your CL https://chrome-internal-review.googlesource.com/#/c/150865/ .
6 years, 12 months ago (2013-12-27 09:42:38 UTC) #1
Maria
lgtm
6 years, 11 months ago (2014-01-02 19:17:21 UTC) #2
Yaron
On 2014/01/02 19:17:21, Maria wrote: > lgtm lgtm Can you do this more generally if ...
6 years, 11 months ago (2014-01-06 17:18:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/105173003/1
6 years, 11 months ago (2014-01-06 19:19:45 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242061
6 years, 11 months ago (2014-01-06 23:29:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/105173003/1
6 years, 11 months ago (2014-01-06 23:42:25 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 23:45:14 UTC) #7
Message was sent while issue was closed.
Change committed as 243203

Powered by Google App Engine
This is Rietveld 408576698