Issue 1051713007: Revert "First iteration on custom layout."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1051713007: Revert "First iteration on custom layout." (Closed)

Created:
5 years, 8 months ago by qsr

Modified:
5 years, 8 months ago

Reviewers:
ojan

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Revert "First iteration on custom layout." This reverts commit 4223122b79f5f7740bb2957138d14a63a2cea8d2. This breaks sky tests. TBR=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/44cf3b689cda2632fa649e2cd3fdbfcb7174f352

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -185 lines)			Patch
M	sky/engine/core/core.gni	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/dom/Element.h	View	3 chunks	+0 lines, -17 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	3 chunks	+0 lines, -66 lines	0 comments	Download
M	sky/engine/core/dom/Element.idl	View	2 chunks	+0 lines, -7 lines	0 comments	Download
D	sky/engine/core/layout/LayoutCallback.h	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	sky/engine/core/layout/LayoutCallback.idl	View	1 chunk	+0 lines, -7 lines	0 comments	Download
D	sky/engine/core/rendering/RenderCustomLayout.h	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	sky/engine/core/rendering/RenderCustomLayout.cpp	View	1 chunk	+0 lines, -42 lines	0 comments	Download

Total messages: 2 (0 generated)

qsr

5 years, 8 months ago (2015-04-02 08:38:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
44cf3b689cda2632fa649e2cd3fdbfcb7174f352 (presubmit successful).