runtime/vm/parser.cc - Issue 1051713005: Avoid caching thread in parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 1051713005: Avoid caching thread in parser. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/parser.cc

===================================================================

--- runtime/vm/parser.cc (revision 44851)

+++ runtime/vm/parser.cc (working copy)

@@ -62,7 +62,7 @@

// Quick access to the current isolate and zone.

-#define I (thread()->isolate())

+#define I (isolate())

#define Z (zone())

@@ -318,7 +318,7 @@

// For parsing a compilation unit.

Parser::Parser(const Script& script, const Library& library, intptr_t token_pos)

- : thread_(Thread::Current()),

+ : isolate_(Thread::Current()->isolate()),

script_(Script::Handle(zone(), script.raw())),

tokens_iterator_(TokenStream::Handle(zone(), script.tokens()),

token_pos),

@@ -347,7 +347,7 @@

Parser::Parser(const Script& script,

ParsedFunction* parsed_function,

intptr_t token_position)

- : thread_(Thread::Current()),

+ : isolate_(Thread::Current()->isolate()),

script_(Script::Handle(zone(), script.raw())),

tokens_iterator_(TokenStream::Handle(zone(), script.tokens()),

token_position),

« no previous file with comments | « runtime/vm/parser.h ('k') | no next file » | no next file with comments »