Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 1051713003: Disabling Automation apitest mixins. (Closed)

Created:
5 years, 8 months ago by shreeramk
Modified:
5 years, 8 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling Automation apitest mixins. This will be enabled once blink CL https://codereview.chromium.org/1045693002/ related to textarea will be rolled in. BUG=471152 TBR=aboxhall Committed: https://crrev.com/bd43a54c6b5dbda1e79c197760a03d9e44aaa0c8 Cr-Commit-Position: refs/heads/master@{#323254}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/automation/automation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
shreeramk
PTAL. Thanks!
5 years, 8 months ago (2015-04-01 04:37:53 UTC) #2
shreeramk
On 2015/04/01 04:37:53, shreeramk wrote: > PTAL. Thanks! The test is to check role textarea ...
5 years, 8 months ago (2015-04-01 04:40:21 UTC) #3
dmazzoni
lgtm
5 years, 8 months ago (2015-04-01 04:44:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051713003/1
5 years, 8 months ago (2015-04-01 04:44:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/53180)
5 years, 8 months ago (2015-04-01 04:54:08 UTC) #8
shreeramk
aboxhall@chromium.org: Owners LGTM req.
5 years, 8 months ago (2015-04-01 05:10:41 UTC) #10
dmazzoni
lgtm I'll land this with tbr:aboxhall
5 years, 8 months ago (2015-04-01 16:22:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1051713003/1
5 years, 8 months ago (2015-04-01 16:23:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 16:27:30 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 16:28:08 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd43a54c6b5dbda1e79c197760a03d9e44aaa0c8
Cr-Commit-Position: refs/heads/master@{#323254}

Powered by Google App Engine
This is Rietveld 408576698